In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001441 [In-Portal CMS] Optimization bug report always 2012-11-11 23:42 2012-12-04 03:53
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status resolved   OS
  OS Version
ETA none Fixed in Version 5.2.1-B2 Product Version 5.2.0
  Target Version 5.2.1 Product Build
Time EstimateNo estimate
Summary 0001441: Separate Module Installation with Class Constants in Unit Config
Description When doing separate module installation, then it's "constants.php" file isn't included during Application initialization because module isn't installed yet.

This creates Fatal Error in case if classes defined in "constants.php" are used inside unit configs of this not yet installed module.

As a solution I'm proposing to add these lines:
$constants_file = FULL_PATH . '/' . $module_folder . '/constants.php';

if ( file_exists($constants_file) ) {
    require_once $constants_file;
}

after these lines:
include_once(FULL_PATH . '/core/kernel/startup.php');
require_once FULL_PATH . '/core/install/install_toolkit.php';

in each module's install.php file.
Steps To Reproduce
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/e3BqcErYvfw/discussion
Change Log Message Separated Module Installation with Class Constants in Unit Config
Estimate Points 1
Attached Files patch file icon installation_constants_1441_modules.patch [^] (3,214 bytes) 2012-12-03 09:40 [Show Content]
patch file icon installation_constants_modules_v2.patch [^] (19,214 bytes) 2012-12-04 03:48 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0005303)
erik (manager)
2012-12-03 09:41

Patch attached. Needs testing
User avatar (0005310)
alex (manager)
2012-12-04 03:50

File "installation_constants_modules_v2.patch" just has reformatted code.
User avatar (0005311)
alex (manager)
2012-12-04 03:53

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001441: Separate Module Installation with Class Constants in Unit Config

- Related Changesets
Modules :: In-Bulletin: 5.2.x r15648
Timestamp: 2012-12-04 03:53:05
Author: alex
Details ] Diff ]
Fixes 0001441: Separate Module Installation with Class Constants in Unit Config
mod - /modules/in-bulletin/branches/5.2.x/install.php Diff ] File ]
Modules :: In-Commerce: 5.2.x r15647
Timestamp: 2012-12-04 03:52:55
Author: alex
Details ] Diff ]
Bug 0001441: Separate Module Installation with Class Constants in Unit Config
mod - /w/in-commerce/branches/5.2.x/install.php Diff ] File ]
Modules :: In-Link: 5.2.x r15645
Timestamp: 2012-12-04 03:52:42
Author: alex
Details ] Diff ]
Bug 0001441: Separate Module Installation with Class Constants in Unit Config
mod - /modules/in-link/branches/5.2.x/install.php Diff ] File ]
Modules :: In-News: 5.2.x r15644
Timestamp: 2012-12-04 03:52:36
Author: alex
Details ] Diff ]
Bug 0001441: Separate Module Installation with Class Constants in Unit Config
mod - /modules/in-news/branches/5.2.x/install.php Diff ] File ]
Modules :: Custom: 1.2.x r15643
Timestamp: 2012-12-04 03:52:28
Author: alex
Details ] Diff ]
Bug 0001441: Separate Module Installation with Class Constants in Unit Config
mod - /modules/custom/branches/1.2.x/install.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-12-04 03:53 alex Note Added: 0005311
2012-12-04 03:53 alex Status reviewed and tested => resolved
2012-12-04 03:53 alex Fixed in Version => 5.2.1-B2
2012-12-04 03:53 alex Resolution open => fixed
2012-12-04 03:53 alex Changeset attached 5.2.x r15648
2012-12-04 03:52 alex Changeset attached 5.2.x r15647
2012-12-04 03:52 alex Changeset attached 5.2.x r15646
2012-12-04 03:52 alex Changeset attached 5.2.x r15645
2012-12-04 03:52 alex Changeset attached 5.2.x r15644
2012-12-04 03:52 alex Changeset attached 1.2.x r15643
2012-12-04 03:50 alex Status needs testing => reviewed and tested
2012-12-04 03:50 alex Note Added: 0005310
2012-12-04 03:48 alex File Added: installation_constants_modules_v2.patch
2012-12-03 09:41 erik Note Added: 0005303
2012-12-03 09:41 erik Assigned To => alex
2012-12-03 09:41 erik Developer => erik
2012-12-03 09:41 erik Status active => needs testing
2012-12-03 09:40 erik File Added: installation_constants_1441_modules.patch
2012-11-11 23:42 Dmitry Estimate Points 0 => 1
2012-11-11 23:42 Dmitry New Issue
2012-11-11 23:42 Dmitry Reference => https://groups.google.com/d/topic/in-portal-bugs/e3BqcErYvfw/discussion
2012-11-11 23:42 Dmitry Change Log Message => Separated Module Installation with Class Constants in Unit Config
2012-11-11 23:42 Dmitry Estimate Points => 0



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker