In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001431

[In-Portal CMS] Data Management

bug report

always

2012-11-05 10:56

2012-11-07 07:50

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

resolved

OS

OS Version

ETA

none

Fixed in Version

5.2.1-B1

Product Version

5.2.0

Target Version

5.2.1

Product Build

Time Estimate

No estimate

Summary

0001431: Change timezone changing code (PHP 5.4 compatibility)

Description

We should use date_default_timezone_set($timezone) function instead of putenv('TZ=' . $timezone); because this no longer works in PHP 5.4.

Steps To Reproduce

Additional Information

See http://lv.php.net/manual/en/migration54.incompatible.php for more information.

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/sUl43axkZdQ/discussion

Change Log Message

Fixes timezone setting problem in PHP 5.4

Estimate Points

1

timezone_sending_code_1431.patch [^] (629 bytes) 2012-11-07 04:54 [Show Content]

Index: application.php
===================================================================
--- application.php	(revision 15602)
+++ application.php	(working copy)
@@ -346,7 +346,7 @@
 		$site_timezone = $this->ConfigValue('Config_Site_Time');
 
 		if ( $site_timezone ) {
-			putenv('TZ=' . $site_timezone);
+			date_default_timezone_set($site_timezone);
 		}
 
 		if ( defined('DEBUG_MODE') && $this->isDebugMode() ) {
@@ -2006,7 +2006,7 @@
 		$user_timezone = $this->Session->GetField('TimeZone');
 
 		if ( $user_timezone ) {
-			putenv('TZ=' . $user_timezone);
+			date_default_timezone_set($user_timezone);
 		}
 	}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0005258) erik (manager) 2012-11-07 04:56	Done, needs testing

(0005270) alex (manager) 2012-11-07 07:49	OK

(0005271) alex (manager) 2012-11-07 07:50	Fix committed to 5.2.x branch. Commit Message: Fixes 0001431: Change timezone changing code (PHP 5.4 compatibility) Commit on behalf of Erik

Related Changesets
In-Portal CMS: 5.2.x r15616 Timestamp: 2012-11-07 07:50:29 Author: alex [ Details ] [ Diff ]	Fixes 0001431: Change timezone changing code (PHP 5.4 compatibility) Commit on behalf of Erik
	mod - /in-portal/branches/5.2.x/core/kernel/application.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-11-07 07:50	alex	Note Added: 0005271
2012-11-07 07:50	alex	Status	reviewed and tested => resolved
2012-11-07 07:50	alex	Fixed in Version	=> 5.2.1-B1
2012-11-07 07:50	alex	Resolution	open => fixed
2012-11-07 07:50	alex	Assigned To	!COMMUNITY => alex
2012-11-07 07:50	alex	Changeset attached	5.2.x r15616
2012-11-07 07:49	alex	Note Added: 0005270
2012-11-07 07:49	alex	Assigned To	=> !COMMUNITY
2012-11-07 07:49	alex	Status	needs testing => reviewed and tested
2012-11-07 04:56	erik	Note Added: 0005258
2012-11-07 04:56	erik	Developer	=> erik
2012-11-07 04:56	erik	Status	active => needs testing
2012-11-07 04:54	erik	File Added: timezone_sending_code_1431.patch
2012-11-05 10:56	alex	New Issue
2012-11-05 10:56	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/sUl43axkZdQ/discussion
2012-11-05 10:56	alex	Change Log Message	=> Fixes timezone setting problem in PHP 5.4
2012-11-05 10:56	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group