In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001406 [In-Portal CMS] Front End bug report always 2012-09-27 05:48 2012-09-27 05:54
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status resolved   OS
  OS Version
ETA none Fixed in Version 5.2.1-B1 Product Version 5.1.1
  Target Version 5.2.1 Product Build
Time EstimateNo estimate
Summary 0001406: Violation of one url = one resource seo rule on login/logout
Description There is a SEO rule, where 1 page content must have exactly 1 (and not more) url to it. If page content changes you:

* either must send proper caching headers (which In-Portal doesn't do at all)
* or change page url

But if we show user-specific content (content that is one for logged-in users and other for non logged-in users) on a page, then, because we have same url to that page, browser can agressively cache it resulting after logout user being presented with logged-in only page version.


This wasn't a problem before, but now once Google Chrome v21 (with MacBook Pro Retina support) is out it actually used it. I saw this on Vista (not Windows 7):

1. visit website (you're not logged in)
2. see "please login" sidebox on the left (while on home page)
3. login
4. browse through website
5. press logout link
6. see logged-in side box on the left instead of "please login" side box

Despite long story problem is quite easy to fix:
- add "?login=1 parameter to page url where user is redirected after login
- add "?logout=1 parameter to page url where user is redirected after logout
Steps To Reproduce
Additional Information Also content language negotiation redirect might not pass login state (login/logout parameter) to url where it redirects user.
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/ynLYg8DMW9I/discussion
Change Log Message Fixes page reload problem after login on Chrome
Estimate Points 1
Attached Files patch file icon track_login_state_in_url_fix.patch [^] (9,286 bytes) 2012-09-27 05:48 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0005185)
alex (manager)
2012-09-27 05:52

As a bonus I've also changed logout code to allow optional redirect to page in "next_template" url parameter. Login code has this option all the time.
User avatar (0005186)
alex (manager)
2012-09-27 05:53

Will test all together later.
User avatar (0005187)
alex (manager)
2012-09-27 05:54

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001406: Violation of one url = one resource seo rule on login/logout

- Related Changesets
In-Portal CMS: 5.2.x r15545
Timestamp: 2012-09-27 05:54:08
Author: alex
Details ] Diff ]
Fixes 0001406: Violation of one url = one resource seo rule on login/logout
mod - /in-portal/branches/5.2.x/core/units/helpers/user_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/languages/languages_item.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/users/users_event_handler.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-09-27 05:54 alex Changeset attached 5.2.x r15545
2012-09-27 05:54 alex Note Added: 0005187
2012-09-27 05:54 alex Status reviewed and tested => resolved
2012-09-27 05:54 alex Fixed in Version => 5.2.1-B1
2012-09-27 05:54 alex Resolution open => fixed
2012-09-27 05:54 alex Assigned To !COMMUNITY => alex
2012-09-27 05:53 alex Note Added: 0005186
2012-09-27 05:53 alex Status needs testing => reviewed and tested
2012-09-27 05:52 alex Note Added: 0005185
2012-09-27 05:49 alex Assigned To => !COMMUNITY
2012-09-27 05:49 alex Developer => alex
2012-09-27 05:49 alex Status active => needs testing
2012-09-27 05:49 alex Additional Information Updated View Revisions
2012-09-27 05:48 alex New Issue
2012-09-27 05:48 alex File Added: track_login_state_in_url_fix.patch
2012-09-27 05:48 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/ynLYg8DMW9I/discussion
2012-09-27 05:48 alex Change Log Message => Fixes page reload problem after login on Chrome
2012-09-27 05:48 alex Estimate Points => 1



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker