In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001392

[In-Portal CMS] Front End

bug report

always

2012-09-13 06:00

2012-09-13 06:03

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

resolved

OS Version

ETA

none

Fixed in Version

5.2.1-B1

Product Version

5.0.0

Target Version

5.2.1

Product Build

Time Estimate

No estimate

Summary

0001392: Resizing non-uploaded image caused fatal error

Description

When image upload isn't required then this means that there are no 100% guarantee that image will be there.

For such cases in template, where image will be displayed we:

* either display default image, e.g. <inp2:unit-prefix_Field name="ImageField" format="resize:100x100;default:img/no_image.gif"/>
* or place <inp2:m_if check="unit-prefix_Field" name="ImageField" db="db"> ... </inp2:m_if> around image display code

If none of mentioned above happens then horrible fatal error happens, that results in "The connection was reset" message being returned from a web server with no idea about what caused it.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/DVhNjWfkTkM/discussion

Change Log Message

Fixes fatal error on missing image display attempt

Estimate Points

Attached Files

missing_image_results_in_fatal_error.patch [^] (469 bytes) 2012-09-13 06:00 [Show Content]

Index: kernel/utility/formatters/upload_formatter.php
===================================================================
--- kernel/utility/formatters/upload_formatter.php	(revision 15462)
+++ kernel/utility/formatters/upload_formatter.php	(working copy)
@@ -486,7 +486,7 @@
 	 */
 	function GetFormatted($value, $field_name, &$object, $format = NULL, $force_direct_links = NULL)
 	{
-		if ( !$format ) {
+		if ( !$format || !$value ) {
 			return $value;
 		}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0005172) alex (manager) 2012-09-13 06:03	Will test all together later.

(0005173) alex (manager) 2012-09-13 06:03	Fix committed to 5.2.x branch. Commit Message: Fixes 0001392: Resizing non-uploaded image caused fatal error

Related Changesets
In-Portal CMS: 5.2.x r15534 Timestamp: 2012-09-13 06:03:35 Author: alex [ Details ] [ Diff ]	Fixes 0001392: Resizing non-uploaded image caused fatal error
	mod - /in-portal/branches/5.2.x/core/kernel/utility/formatters/upload_formatter.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-09-13 06:03	alex	Note Added: 0005173
2012-09-13 06:03	alex	Status	reviewed and tested => resolved
2012-09-13 06:03	alex	Fixed in Version	=> 5.2.1-B1
2012-09-13 06:03	alex	Resolution	open => fixed
2012-09-13 06:03	alex	Assigned To	!COMMUNITY => alex
2012-09-13 06:03	alex	Changeset attached	5.2.x r15534
2012-09-13 06:03	alex	Note Added: 0005172
2012-09-13 06:03	alex	Status	needs testing => reviewed and tested
2012-09-13 06:02	alex	Assigned To	=> !COMMUNITY
2012-09-13 06:02	alex	Developer	=> alex
2012-09-13 06:02	alex	Status	active => needs testing
2012-09-13 06:02	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/DVhNjWfkTkM/discussion
2012-09-13 06:00	alex	New Issue
2012-09-13 06:00	alex	File Added: missing_image_results_in_fatal_error.patch
2012-09-13 06:00	alex	Change Log Message	=> Fixes fatal error on missing image display attempt
2012-09-13 06:00	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS