In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001326

[In-Portal CMS] Data Management

bug report

always

2012-06-16 11:34

2012-07-25 05:29

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.2.0

Product Version

5.2.0-B1

Target Version

5.2.0

Product Build

Time Estimate

No estimate

Summary

0001326: Fatal error when trying to use parser tag caching in 5.2.0 on PHP version below 5.3.1

Description

In PHP 5.3.1+ some OOP internals code was changed (see http://php.net/manual/en/language.oop5.visibility.php) resulting in ability for 2 classes sharing same parent class being able to access protected parent class properties.

This seemed a bug to me and some other PHP community members (see https://bugs.php.net/bug.php?id=50892 and http://youtrack.jetbrains.com/issue/WI-11713?projectKey=WI) at first, but it's how it works and nobody seem to disagree with it, since it's works in exactly same way as it works in Java, which is famous with it's OOP implementation.

I'm talking about this here, because in In-Portal 5.2.x we've made some changes that create 1 line of code, where exactly this change is exploited resulting a fatal error (only in code that uses tag caching), when somebody installs In-Portal 5.2.0+ on his webserver, which has PHP version below 5.3.1.
I'm attaching a patch for users, who want to use In-Portal 5.2.0+ installation (+tag caching) on PHP 5.2.x and above.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/Hv9rG64UDfE/discussion

Change Log Message

Fixes protected member access from PHP 5.2.x and below

Estimate Points

2

fatal_error_on_home_page_with_tag_caching_enabled_520.patch [^] (686 bytes) 2012-06-16 11:34 [Show Content]

Index: nparser.php
===================================================================
--- nparser.php	(revision 15364)
+++ nparser.php	(working copy)
@@ -567,9 +567,9 @@
 
 			// don't use kDBItem::Update(), because it will change ModifiedById to current front-end user
 			$sql = 'UPDATE ' . $page->TableName . '
-					SET PageCacheKey = ' . $page->Conn->qstr($page_cache_key) . '
+					SET PageCacheKey = ' . $this->Conn->qstr($page_cache_key) . '
 					WHERE ' . $page->IDField . ' = ' . $page->GetID();
-			$page->Conn->Query($sql);
+			$this->Conn->Query($sql);
 
 			// increment serial, because we issue direct sql above!
 			$this->Application->incrementCacheSerial('c');

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.1.0)

Implement "MemCached" functionality

Notes
(0004729) alex (manager) 2012-06-16 11:35	Will test all together later.

(0004730) alex (manager) 2012-06-16 11:35	Fix committed to 5.2.x branch. Commit Message: Fixes 0001326: Fatal error when trying to use parser tag caching in 5.2.0 on PHP version below 5.3.1

(0004860) alex (manager) 2012-07-25 05:29	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15412 Timestamp: 2012-06-16 11:35:59 Author: alex [ Details ] [ Diff ]	Fixes 0001326: Fatal error when trying to use parser tag caching in 5.2.0 on PHP version below 5.3.1
	mod - /in-portal/branches/5.2.x/core/kernel/nparser/nparser.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-08-11 12:20	Dmitry	Relationship added	related to 0000107
2012-07-25 05:29	alex	Note Added: 0004860
2012-07-25 05:29	alex	Status	resolved => closed
2012-06-16 11:36	alex	Changeset attached	5.2.x r15412
2012-06-16 11:35	alex	Note Added: 0004730
2012-06-16 11:35	alex	Status	reviewed and tested => resolved
2012-06-16 11:35	alex	Fixed in Version	=> 5.2.0
2012-06-16 11:35	alex	Resolution	open => fixed
2012-06-16 11:35	alex	Assigned To	!COMMUNITY => alex
2012-06-16 11:35	alex	Note Added: 0004729
2012-06-16 11:35	alex	Status	needs testing => reviewed and tested
2012-06-16 11:35	alex	Assigned To	=> !COMMUNITY
2012-06-16 11:35	alex	Developer	=> alex
2012-06-16 11:35	alex	Status	active => needs testing
2012-06-16 11:35	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/Hv9rG64UDfE/discussion
2012-06-16 11:34	alex	New Issue
2012-06-16 11:34	alex	File Added: fatal_error_on_home_page_with_tag_caching_enabled_520.patch
2012-06-16 11:34	alex	Change Log Message	=> Fixes protected member access from PHP 5.2.x and below
2012-06-16 11:34	alex	Estimate Points	=> 2

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group