In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001309

[In-Portal CMS] Data Management

bug report

always

2012-06-03 00:23

2012-07-25 05:29

Reporter

Dmitry

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.2.0-RC1

Product Version

5.0.0

Target Version

5.2.0

Product Build

Time Estimate

No estimate

Summary

0001309: Incorrect behavior of "has_sub_menu" param in CachedMenu

Description

Bug in our CachedMenu tag (prints cached version of the menu) related to detection of active sub-menus on 2+ level of the menu.

There is a special param called "has_sub_menu" which allows you to check if current menu level (when printed using CachedMenu tag) has any Active + Visible sections inside of it which helps you to decide if sub-menu with these sections will be printed/shown.

This param worked well for 1st level of the menu, but didn't check for Section Menu Visibility on 2+ levels of the Menu.

See attached screenshot.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/A0l7Fa03mlg/discussion

Change Log Message

Fixed oncorrect behavior of "has_sub_menu" param in CachedMenu

Estimate Points

1

In-Portal_--_Empty_Sub-menu.png [^] (74,365 bytes) 2012-06-03 00:23

issue_with_empty_sub-menu.patch [^] (800 bytes) 2012-06-03 00:23 [Show Content]

Index: core/units/helpers/menu_helper.php
===================================================================
--- core/units/helpers/menu_helper.php	(revision 15379)
+++ core/units/helpers/menu_helper.php	(working copy)
@@ -240,7 +240,7 @@
 				'item_type' => $page['ItemType'],
 				'page_id' => $page['ItemId'],
 				'use_section' => ($page['Type'] == PAGE_TYPE_TEMPLATE) && ($page['ItemPath'] != 'index'),
-				'has_sub_menu' => isset($page['sub_items']) && count($page['sub_items']) > 0,
+				'has_sub_menu' => isset($page['sub_items']) && count($this->_removeNonMenuItems($page['sub_items'])) > 0,
 				'external_url' => $page['UseExternalUrl'] ? $page['ExternalUrl'] : false, // for backward compatibility
 				'menu_icon' => $page['UseMenuIconUrl'] ? $page['MenuIconUrl'] : false,
 			);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004702) Dmitry (manager) 2012-06-03 00:24	Patch attached - please test and review

(0004710) alex (manager) 2012-06-05 12:44	Will test all together later.

(0004711) alex (manager) 2012-06-05 12:44	Fix committed to 5.2.x branch. Commit Message: Fixes 0001309: Incorrect behavior of "has_sub_menu" param in CachedMenu

(0004869) alex (manager) 2012-07-25 05:29	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15384 Timestamp: 2012-06-05 12:44:34 Author: alex [ Details ] [ Diff ]	Fixes 0001309: Incorrect behavior of "has_sub_menu" param in CachedMenu
	mod - /in-portal/branches/5.2.x/core/units/helpers/menu_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:29	alex	Note Added: 0004869
2012-07-25 05:29	alex	Status	resolved => closed
2012-06-05 12:44	alex	Changeset attached	5.2.x r15384
2012-06-05 12:44	alex	Note Added: 0004711
2012-06-05 12:44	alex	Status	reviewed and tested => resolved
2012-06-05 12:44	alex	Fixed in Version	=> 5.2.0-RC1
2012-06-05 12:44	alex	Resolution	open => fixed
2012-06-05 12:44	alex	Assigned To	!COMMUNITY => alex
2012-06-05 12:44	alex	Note Added: 0004710
2012-06-05 12:44	alex	Status	needs testing => reviewed and tested
2012-06-05 12:43	alex	Estimate Points	0 => 1
2012-06-03 00:26	Dmitry	Reference	[/url] => [url]https://groups.google.com/d/topic/in-portal-bugs/A0l7Fa03mlg/discussion
2012-06-03 00:26	Dmitry	Developer	Dmitry => alex
2012-06-03 00:24	Dmitry	Note Added: 0004702
2012-06-03 00:24	Dmitry	Assigned To	=> !COMMUNITY
2012-06-03 00:24	Dmitry	Developer	=> Dmitry
2012-06-03 00:24	Dmitry	Status	active => needs testing
2012-06-03 00:23	Dmitry	File Added: issue_with_empty_sub-menu.patch
2012-06-03 00:23	Dmitry	New Issue
2012-06-03 00:23	Dmitry	File Added: In-Portal_--_Empty_Sub-menu.png
2012-06-03 00:23	Dmitry	Reference	=> [url][/url]
2012-06-03 00:23	Dmitry	Change Log Message	=> Fixed oncorrect behavior of "has_sub_menu" param in CachedMenu
2012-06-03 00:23	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group