In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001302

[In-Portal CMS] Template System

bug report

always

2012-05-29 05:39

2012-07-25 05:30

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.2.0-RC1

Product Version

5.0.0

Target Version

5.2.0

Product Build

Time Estimate

No estimate

Summary

0001302: Parameters js_escape, html_escape, strip_nl, trim are ignored by <inp2:m_include .../> tag

Description

One of the powerful In-Portal features is an ability to create blocks of HTML that can be reused multiple times later. For example:

<inp2:m_DefineElement name="some_element">
... some html here ...
</inp2:m_DefineElement/>

Then these elements can be used via <inp2:m_RenderElement name="some_element"/> tag in any template.

Usually we have multiple blocks definitions in a dedicated templates and you need to include that template via <inp2:m_include template="path/to/block_definitions/template"/> tag to be able to use them.
To increase readability of these files (that only contains blocks) we add some empty lines between block declarations. As a result all these empty lines between block declarations are added into resulting HTML page.

To solve it we started adding strip_nl="2" parameter into m_include tag, like this <inp2:m_include template="path/to/block_definitions/template" strip_nl="2"/>, but it wasn't ever processed by that tag.
After a deeper investigation I've found that none of:
* js_escape
* html_escape
* strip_nl
* trim
are being processed in that tag.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/b_iOr5-85MM/discussion

Change Log Message

Fixes problem, where m_include tag wasn't processing strip_nl parameter

Estimate Points

1

strip_nl_not_working_in_m_include_tag.patch [^] (641 bytes) 2012-05-29 05:39 [Show Content]

Index: kernel/nparser/nparser.php
===================================================================
--- kernel/nparser/nparser.php	(revision 15359)
+++ kernel/nparser/nparser.php	(working copy)
@@ -881,10 +881,15 @@
 			$params = array_merge($this->Params, $params);
 		}
 
+		$m_processor =& $this->GetProcessor('m');
+		$flag_values = $m_processor->PreparePostProcess($params);
+
 		$this->PushParams($params);
 		$ret = $this->Run($t, $silent);
 		$this->PopParams();
 
+		$ret = $m_processor->PostProcess($ret, $flag_values);
+
 		$this->CheckNoData($ret, $params);
 		$this->DataExists = $data_exists_bak || $this->DataExists;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004672) alex (manager) 2012-05-29 05:41	Will test all together later.

(0004673) alex (manager) 2012-05-29 05:41	Fix committed to 5.2.x branch. Commit Message: Fixes 0001302: Parameters js_escape, html_escape, strip_nl, trim are ignored by <inp2:m_include .../> tag

(0004886) alex (manager) 2012-07-25 05:30	Since 5.2.0/1.2.0 versions was released.

Related Changesets
In-Portal CMS: 5.2.x r15364 Timestamp: 2012-05-29 05:41:35 Author: alex [ Details ] [ Diff ]	Fixes 0001302: Parameters js_escape, html_escape, strip_nl, trim are ignored by <inp2:m_include .../> tag
	mod - /in-portal/branches/5.2.x/core/kernel/nparser/nparser.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:30	alex	Note Added: 0004886
2012-07-25 05:30	alex	Status	resolved => closed
2012-05-29 05:41	alex	Note Added: 0004673
2012-05-29 05:41	alex	Status	reviewed and tested => resolved
2012-05-29 05:41	alex	Fixed in Version	=> 5.2.0-RC1
2012-05-29 05:41	alex	Resolution	open => fixed
2012-05-29 05:41	alex	Assigned To	!COMMUNITY => alex
2012-05-29 05:41	alex	Changeset attached	5.2.x r15364
2012-05-29 05:41	alex	Note Added: 0004672
2012-05-29 05:41	alex	Status	needs testing => reviewed and tested
2012-05-29 05:40	alex	Assigned To	=> !COMMUNITY
2012-05-29 05:40	alex	Developer	=> alex
2012-05-29 05:40	alex	Status	active => needs testing
2012-05-29 05:40	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/b_iOr5-85MM/discussion
2012-05-29 05:39	alex	New Issue
2012-05-29 05:39	alex	File Added: strip_nl_not_working_in_m_include_tag.patch
2012-05-29 05:39	alex	Change Log Message	=> Fixes problem, where m_include tag wasn't processing strip_nl parameter
2012-05-29 05:39	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group