In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/KpBHTkC5zHg/discussion

Change Log Message

Adds missing Hint & Column translation fields to phrase editing screen when in non-debug mode

Estimate Points

Attached Files

hint_and_column_translations_in_debug_mode.patch [^] (4,603 bytes) 2012-03-31 04:25 [Show Content]

Index: admin/system_presets/simple/phrases_phrases.php
===================================================================
--- admin/system_presets/simple/phrases_phrases.php	(revision 15165)
+++ admin/system_presets/simple/phrases_phrases.php	(working copy)
@@ -36,7 +36,7 @@
 	);
 
 	$debug_only_fields = Array (
-//		'HintTranslation', 'ColumnTranslation'
+		'HintTranslation', 'ColumnTranslation'
 	);
 
 	// fields to make required
Index: core/admin_templates/languages/phrase_edit.tpl
===================================================================
--- core/admin_templates/languages/phrase_edit.tpl	(revision 15165)
+++ core/admin_templates/languages/phrase_edit.tpl	(working copy)
@@ -71,15 +71,15 @@
 	<inp2:m_RenderElement name="inp_edit_hidden" prefix="phrases" field="Phrase"/>
 </inp2:m_if>
 
+<inp2:m_DefineElement name="translations_element">
+	<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="Translation" style="width: 100%; height: 100px;" control_options="{max_height: 100}" allow_html="0"/>
+	<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="HintTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
+	<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="ColumnTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="phrase_element">
 	<inp2:m_if check="m_Get" name="simple_mode">
-		<inp2:m_if check="m_IsDebugMode">
-			<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="Translation" style="width: 100%; height: 100px;" control_options="{max_height: 100}" allow_html="0"/>
-			<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="HintTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
-			<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="ColumnTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
-		<inp2:m_else/>
-			<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="Translation" title="la_fld_Translation" rows="7" cols="50" allow_html="0"/>
-		</inp2:m_if>
+		<inp2:m_RenderElement name="translations_element"/>
 	<inp2:m_else/>
 		<tr class="subsectiontitle">
 			<td colspan="3"><inp2:phrases_Field name="Phrase"/></td>
@@ -87,10 +87,9 @@
 
 		<inp2:m_RenderElement name="inp_label" prefix="phrases" field="PrimaryTranslation"/>
 		<inp2:m_RenderElement name="inp_edit_box" prefix="phrases" field="Phrase" size="60"/>
-		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="Translation" style="width: 100%; height: 100px;" control_options="{max_height: 100}" allow_html="0"/>
-		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="HintTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
-		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="ColumnTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
 
+		<inp2:m_RenderElement name="translations_element"/>
+
 		<inp2:m_RenderElement name="inp_label" prefix="phrases" field="PhraseType"/>
 		<inp2:m_RenderElement name="inp_edit_options" prefix="phrases" field="Module" has_empty="1"/>
 	</inp2:m_if>
Index: core/admin_templates/regional/phrases_edit.tpl
===================================================================
--- core/admin_templates/regional/phrases_edit.tpl	(revision 15165)
+++ core/admin_templates/regional/phrases_edit.tpl	(working copy)
@@ -80,6 +80,7 @@
 
 		<inp2:m_RenderElement name="inp_label" prefix="phrases" field="PrimaryTranslation"/>
 		<inp2:m_RenderElement name="inp_edit_box" prefix="phrases" field="Phrase" size="60"/>
+
 		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="l{$language_id}_Translation" title="la_fld_Translation" style="width: 100%; height: 100px;" control_options="{max_height: 100}" allow_html="0"/>
 		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="l{$language_id}_HintTranslation" title="la_fld_HintTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>
 		<inp2:m_RenderElement name="inp_edit_textarea_ml" prefix="phrases" field="l{$language_id}_ColumnTranslation" title="la_fld_ColumnTranslation" style="width: 100%; height: 50px;" control_options="{max_height: 50}" allow_html="0"/>

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

0001094

closed (5.1.3)

alex

Optimizing storage of help phrases

Notes
(0004546) alex (manager) 2012-03-31 04:28	Will test all together later.

(0004547) alex (manager) 2012-03-31 04:29	Fix committed to 5.2.x branch. Commit Message: Fixes 0001242: Hint Translation Not Available When Not in Debug Mode

(0004940) alex (manager) 2012-07-25 05:31	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15254 Timestamp: 2012-03-31 04:29:02 Author: alex [ Details ] [ Diff ]	Fixes 0001242: Hint Translation Not Available When Not in Debug Mode
	mod - /in-portal/branches/5.2.x/admin/system_presets/simple/phrases_phrases.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/languages/phrase_edit.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/regional/phrases_edit.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:31	alex	Note Added: 0004940
2012-07-25 05:31	alex	Status	resolved => closed
2012-03-31 04:29	alex	Note Added: 0004547
2012-03-31 04:29	alex	Status	reviewed and tested => resolved
2012-03-31 04:29	alex	Fixed in Version	=> 5.2.0-B3
2012-03-31 04:29	alex	Resolution	open => fixed
2012-03-31 04:29	alex	Assigned To	!COMMUNITY => alex
2012-03-31 04:29	alex	Changeset attached	5.2.x r15254
2012-03-31 04:28	alex	Note Added: 0004546
2012-03-31 04:28	alex	Status	needs testing => reviewed and tested
2012-03-31 04:28	alex	Relationship added	child of 0001094
2012-03-31 04:26	alex	Assigned To	=> !COMMUNITY
2012-03-31 04:26	alex	Developer	=> alex
2012-03-31 04:26	alex	Status	active => needs testing
2012-03-31 04:25	alex	Reporter	alex => phil
2012-03-31 04:25	alex	version	=> 5.2.0-B2
2012-03-31 04:25	alex	Target Version	=> 5.2.0
2012-03-31 04:25	alex	New Issue
2012-03-31 04:25	alex	File Added: hint_and_column_translations_in_debug_mode.patch
2012-03-31 04:25	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/KpBHTkC5zHg/discussion
2012-03-31 04:25	alex	Change Log Message	=> Adds missing Hint & Column translation fields to phrase editing screen when in non-debug mode
2012-03-31 04:25	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS