In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001199

[In-Portal CMS] Refactoring

task

always

2012-02-01 12:34

2012-07-25 05:31

Reporter

Dmitry

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS Version

ETA

none

Fixed in Version

5.2.0-B2

Product Version

Target Version

5.2.0

Product Build

Time Estimate

No estimate

Summary

0001199: Rename DBG_EMAIL option and Add it to debug_sample.php

Description

We have nice feature, that allows to transfer all e-mails that are sent to given e-mail address.

This is useful in cases, when developer performs some action on a website, that can cause mass mailing and he doesn't want that mails to reach live users.

And since all e-mails are sent to his mailbox he then is able to detect what was happening.

Option is called DBG_EMAIL and can be set to:

e-mail address (e.g. al...@intechnic.com)
e-mail domain (e.g. @intechnic.com)

In later case actual recipient e-mail would be created from original e-mail recipient this way:

1. have user@domain.tld
2. replace @ with _at_
3. append domain from DBG_EMAIL
4. result user_at_d...@intechnic.com

If DBG_EMAIL is defined in $dbg_options array in debug.php file, then it will only work when debug mode is enabled. If there is a need, then it can be defined before $dbg_options array resulting recipient replacing until this option is turn off.

In this task we NEED:

1. Rename DBG_EMAIL to OVERRIDE_EMAIL_RECIPIENTS
2. Make sure it works withi $dbg_options and outside
3. Add it as sample OVERRIDE_EMAIL_RECIPIENTS to tools/debug_sample.php

define('OVERRIDE_EMAIL_RECIPIENTS', ''); // Overwrites email recipients with some-email@domain-name.com or @domain-name.com

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/EBDQtGRcirw/discussion

Change Log Message

added OVERRIDE_EMAIL_RECIPIENTS to debug_sample.php

Estimate Points

Attached Files

email_override_demo.patch [^] (1,492 bytes) 2012-02-07 05:43 [Show Content]

Index: core/kernel/utility/email_send.php
===================================================================
--- core/kernel/utility/email_send.php	(revision 15085)
+++ core/kernel/utility/email_send.php	(working copy)
@@ -1857,13 +1857,13 @@
 		 */
 		function _replaceRecipientEmail($email)
 		{
-			if (defined('DBG_EMAIL') && DBG_EMAIL) {
-				if (substr(DBG_EMAIL, 0, 1) == '@') {
+			if ( defined('OVERRIDE_EMAIL_RECIPIENTS') && OVERRIDE_EMAIL_RECIPIENTS ) {
+				if ( substr(OVERRIDE_EMAIL_RECIPIENTS, 0, 1) == '@' ) {
 					// domain
-					$email = str_replace('@', '_at_', $email) . DBG_EMAIL;
+					$email = str_replace('@', '_at_', $email) . OVERRIDE_EMAIL_RECIPIENTS;
 				}
 				else {
-					$email = DBG_EMAIL;
+					$email = OVERRIDE_EMAIL_RECIPIENTS;
 				}
 			}
 
Index: tools/debug_sample.php
===================================================================
--- tools/debug_sample.php	(revision 15052)
+++ tools/debug_sample.php	(working copy)
@@ -22,6 +22,7 @@
 //	define('DBG_CAPTURE_STATISTICS', 1);		// Capture performance statistics
 //	define('DBG_MAX_SQL_TIME', 2);				// Maximal allowed sql execution time in seconds, all sqls above this become slow sqls
 //	define('DBG_CURL', 1);						// Log all curl requests to CurlLog database table
+//	define('OVERRIDE_EMAIL_RECIPIENTS', '');	// Overwrites email recipients with some-email@domain-name.com or @domain-name.com
 
 	$dbg_options = Array (
 		// !!! DEBUG MODE will be off if IP does not match !!!

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004448) alex (manager) 2012-02-07 05:45	Will test all together later.

(0004449) alex (manager) 2012-02-07 05:45	Fix committed to 5.2.x branch. Commit Message: Fixes 0001199: Rename DBG_EMAIL option and Add it to debug_sample.php

(0004979) alex (manager) 2012-07-25 05:31	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15106 Timestamp: 2012-02-07 05:45:27 Author: alex [ Details ] [ Diff ]	Fixes 0001199: Rename DBG_EMAIL option and Add it to debug_sample.php
	mod - /in-portal/branches/5.2.x/core/kernel/utility/email_send.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/tools/debug_sample.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:31	alex	Note Added: 0004979
2012-07-25 05:31	alex	Status	resolved => closed
2012-02-07 05:45	alex	Note Added: 0004449
2012-02-07 05:45	alex	Status	reviewed and tested => resolved
2012-02-07 05:45	alex	Fixed in Version	=> 5.2.0-B2
2012-02-07 05:45	alex	Resolution	open => fixed
2012-02-07 05:45	alex	Assigned To	!COMMUNITY => alex
2012-02-07 05:45	alex	Changeset attached	5.2.x r15106
2012-02-07 05:45	alex	Note Added: 0004448
2012-02-07 05:45	alex	Status	needs testing => reviewed and tested
2012-02-07 05:44	alex	Assigned To	=> !COMMUNITY
2012-02-07 05:44	alex	Developer	=> alex
2012-02-07 05:44	alex	Status	active => needs testing
2012-02-07 05:43	alex	Estimate Points	0 => 1
2012-02-07 05:43	alex	File Added: email_override_demo.patch
2012-02-01 12:34	Dmitry	New Issue
2012-02-01 12:34	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/EBDQtGRcirw/discussion
2012-02-01 12:34	Dmitry	Change Log Message	=> added OVERRIDE_EMAIL_RECIPIENTS to debug_sample.php
2012-02-01 12:34	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS