In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001183 [In-Portal CMS] Mailing System feature request always 2011-12-23 15:25 2012-07-25 05:32
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.2.0-B1 Product Version
  Target Version 5.2.0 Product Build
Time EstimateNo estimate
Summary 0001183: Separate setting for default Email Sender / Recipients
Description In-Portal has single configuration variable "Messages from Site Admin are from" (Smtp_AdminMailFrom), that is used as default from e-mail for all outgoing e-mail that are sent from the site.

In fact the same configuration variable is used as default recipient for any e-mail, that is sent to administrator from the site (e.g. validate new link e-mail, contact us form was submitted e-mail).
This is inconvinient, since you can't specify multiple admin e-mails because same e-mail list would be used as "From" part of outgoing e-mails and will break them down.

Now you need to go though every e-mail event settings and manually assign admin users to each event and that's inconvenient.


Proposed Solution:

1. Add configuration variable called "DefaultEmailRecipients". Place a standard recipient entering control from "Settings" tab of e-mail event editing page (see attached image) that allows to specify to/cc/bcc. Place it after "Mailing List Send Per Step" variable under "Admin -> Configuration -> Website -> Advanced: Mailing Settings" section.

2. By default use default "from e-mail" that we already have to act as "to e-mail" (for admin email events) in case if to e-mails in a new form haven't been specified.

3. Add same variable to site domain record, since default from e-mail

4. Rename "Smtp_AdminMailFrom" to "DefaultEmailSender" - across the system
Steps To Reproduce
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/BCCyyR097iQ/discussion
Change Log Message Added separate setting for default email sender / recipient
Estimate Points 2
Attached Files png file icon email_recipient_control.png [^] (10,609 bytes) 2011-12-23 15:25


patch file icon separate_default_email_recipients_core.patch [^] (81,313 bytes) 2011-12-29 06:44 [Show Content]
patch file icon separate_default_email_recipients_modules.patch [^] (2,722 bytes) 2011-12-29 06:45 [Show Content]
patch file icon separate_default_email_recipients_themes.patch [^] (867 bytes) 2011-12-29 06:45 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0004344)
alex (manager)
2011-12-29 06:45

Will test all together later.
User avatar (0004345)
alex (manager)
2011-12-29 06:47

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001183: Separate setting for default Email Sender / Recipients
Done Additionally:
1. wrong constants were used on "Settings" tab (e-mail event editing page) resulting JS error
2. e-mail sending to a group, specified on "Settings" tab (e-mail event editing page) wasn't working
User avatar (0005014)
alex (manager)
2012-07-25 05:32

Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14941
Timestamp: 2011-12-29 06:47:14
Author: alex
Details ] Diff ]
Fixes 0001183: Separate setting for default Email Sender / Recipients
Done Additionally:
1. wrong constants were used on "Settings" tab (e-mail event editing page) resulting JS error
2. e-mail sending to a group, specified on "Settings" tab (e-mail event editing page) wasn't working
mod - /in-portal/branches/5.2.x/core/admin_templates/config/custom_variables.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/form_blocks.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/style_template.css Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/languages/email_message_settings.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/site_domains/site_domain_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.css Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/managers/cache_manager.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/configuration/configuration_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/email_events/email_event_tp.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/email_events/email_events_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/mailing_list_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/site_domains/site_domain_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/site_domains/site_domains_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/users/users_tag_processor.php Diff ] File ]
Modules :: In-Commerce: 5.2.x r14940
Timestamp: 2011-12-29 06:46:25
Author: alex
Details ] Diff ]
Bug 0001183: Separate setting for default Email Sender / Recipients
mod - /w/in-commerce/branches/5.2.x/units/gateways/gw_classes/rightconnect.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/gift_certificates/gift_certificates_eh.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/orders/orders_tag_processor.php Diff ] File ]
Themes :: Advanced: 1.2.x r14938
Timestamp: 2011-12-29 06:45:58
Author: alex
Details ] Diff ]
Bug 0001183: Separate setting for default Email Sender / Recipients
mod - /themes/advanced/branches/1.2.x/in-news/elements/rss.xml.tpl Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005014
2012-07-25 05:32 alex Status resolved => closed
2011-12-29 06:47 alex Changeset attached 5.2.x r14941
2011-12-29 06:47 alex Note Added: 0004345
2011-12-29 06:47 alex Status reviewed and tested => resolved
2011-12-29 06:47 alex Fixed in Version => 5.2.0-B1
2011-12-29 06:47 alex Resolution open => fixed
2011-12-29 06:47 alex Assigned To !COMMUNITY => alex
2011-12-29 06:46 alex Changeset attached 5.2.x r14940
2011-12-29 06:46 alex Changeset attached 5.2.x r14939
2011-12-29 06:45 alex Changeset attached 1.2.x r14938
2011-12-29 06:45 alex Note Added: 0004344
2011-12-29 06:45 alex Status needs testing => reviewed and tested
2011-12-29 06:45 alex Assigned To => !COMMUNITY
2011-12-29 06:45 alex Developer => alex
2011-12-29 06:45 alex Status active => needs testing
2011-12-29 06:45 alex File Added: separate_default_email_recipients_themes.patch
2011-12-29 06:45 alex File Added: separate_default_email_recipients_modules.patch
2011-12-29 06:44 alex File Added: separate_default_email_recipients_core.patch
2011-12-29 03:17 alex Estimate Points 0 => 2
2011-12-23 15:27 Dmitry Description Updated View Revisions
2011-12-23 15:25 Dmitry New Issue
2011-12-23 15:25 Dmitry File Added: email_recipient_control.png
2011-12-23 15:25 Dmitry Reference => https://groups.google.com/d/topic/in-portal-dev/BCCyyR097iQ/discussion
2011-12-23 15:25 Dmitry Change Log Message => Added separate setting for default email sender / recipient
2011-12-23 15:25 Dmitry Estimate Points => 0



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker