In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001173

[In-Portal CMS] Template System

feature request

N/A

2011-11-29 02:31

2012-07-25 05:32

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.2.0-B1

Product Version

5.1.3

Target Version

5.2.0

Product Build

Time Estimate

No estimate

Summary

0001173: Wrong template on templates loaded via AJAX requests

Description

In-Portal uses <inp2:m_Link .../> tag to build links to this/other pages of website.

When:
* template is not specified, then link to current page will be created;
* template is specified, then link to given page will be created.

However, when parts of a page are loaded via ajax requests, e.g.

<script type="text/javascript">
$('#target-div').load( '<inp2:m_Link template="path/to/ajax/template" no_amp="1" js_escape="1"/>' );
</script>

then within "path/to/ajax/template" template current template will now be "path/to/ajax/template" instead of template used to display the page that made that ajax request.

Attached patch solves this problem allowing to specify alternative template, that should be used by template parser to display page content. Fixed version of JavaScript code from example above now will look like:

<script type="text/javascript">
$('#target-div').load( '<inp2:m_Link render_template="path/to/ajax/template" no_amp="1" js_escape="1"/>' );
</script>

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/QLILUDfQLOo/discussion

Change Log Message

Fixes wrong current template used inside ajax requests

Estimate Points

1

links_inside_ajax_template_fix.patch [^] (503 bytes) 2011-11-29 02:31 [Show Content]

Index: kernel/application.php
===================================================================
--- kernel/application.php	(revision 14795)
+++ kernel/application.php	(working copy)
@@ -973,7 +973,7 @@
 		$this->EventManager->ProcessRequest();
 
 		$this->InitParser();
-		$t = $this->GetVar('t');
+		$t = $this->GetVar('render_template', $this->GetVar('t'));
 
 		if ( !$this->TemplatesCache->TemplateExists($t) && !$this->isAdmin ) {
 			$cms_handler =& $this->recallObject('st_EventHandler');

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004177) alex (manager) 2011-11-29 02:32	Will test all together later.

(0004178) alex (manager) 2011-11-29 02:33	Fix committed to 5.2.x branch. Commit Message: Fixes 0001173: Wrong template on templates loaded via AJAX requests

(0005045) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14803 Timestamp: 2011-11-29 02:33:25 Author: alex [ Details ] [ Diff ]	Fixes 0001173: Wrong template on templates loaded via AJAX requests
	mod - /in-portal/branches/5.2.x/core/kernel/application.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005045
2012-07-25 05:32	alex	Status	resolved => closed
2011-11-29 02:33	alex	Note Added: 0004178
2011-11-29 02:33	alex	Status	reviewed and tested => resolved
2011-11-29 02:33	alex	Fixed in Version	=> 5.2.0-B1
2011-11-29 02:33	alex	Resolution	open => fixed
2011-11-29 02:33	alex	Assigned To	!COMMUNITY => alex
2011-11-29 02:33	alex	Changeset attached	5.2.x r14803
2011-11-29 02:32	alex	Note Added: 0004177
2011-11-29 02:32	alex	Status	needs testing => reviewed and tested
2011-11-29 02:32	alex	Assigned To	=> !COMMUNITY
2011-11-29 02:32	alex	Developer	=> alex
2011-11-29 02:32	alex	Status	active => needs testing
2011-11-29 02:32	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/QLILUDfQLOo/discussion
2011-11-29 02:31	alex	New Issue
2011-11-29 02:31	alex	File Added: links_inside_ajax_template_fix.patch
2011-11-29 02:31	alex	Change Log Message	=> Fixes wrong current template used inside ajax requests
2011-11-29 02:31	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group