In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/Uhs-9J9H5aY/discussion

Change Log Message

Optimizing ajax requests that are sent to save admin menu frame width

Estimate Points

Attached Files

admin_menu_width_saving_fix.patch [^] (1,504 bytes) 2011-11-07 03:12 [Show Content]

Index: admin_templates/tree.tpl
===================================================================
--- admin_templates/tree.tpl	(revision 14733)
+++ admin_templates/tree.tpl	(working copy)
@@ -5,7 +5,8 @@
 <body class="tree-body" onresize="onTreeFrameResize();">
 
 <script type="text/javascript">
-	var $last_width = parseInt('<inp2:m_GetConfig name="MenuFrameWidth"/>');
+	var $save_timer = null,
+		$last_width = parseInt('<inp2:m_GetConfig name="MenuFrameWidth"/>');
 
 	function credits(url) {
 		openwin(url, 'credits', 280, 520);
@@ -23,6 +24,11 @@
 			return ;
 		}
 
+		clearTimeout($save_timer);
+		$save_timer = setTimeout( function() {saveFrameWidth($width);}, 2000);
+	}
+
+	function saveFrameWidth($width) {
 		getFrame('head').$FrameResizer.OpenWidth = $width;
 
 		$.get(
Index: units/admin/admin_events_handler.php
===================================================================
--- units/admin/admin_events_handler.php	(revision 14733)
+++ units/admin/admin_events_handler.php	(working copy)
@@ -875,14 +875,7 @@
 			return ;
 		}
 
-		$sql = 'UPDATE ' . $this->Application->getUnitOption('conf', 'TableName') . '
-				SET VariableValue = ' . (int)$this->Application->GetVar('width')  . '
-				WHERE VariableName = "MenuFrameWidth"';
-		$this->Conn->Query($sql);
-
-		if ($this->Conn->getAffectedRows()) {
-			$this->Application->DeleteUnitCache(false);
-		}
+		$this->Application->SetConfigValue('MenuFrameWidth', (int)$this->Application->GetVar('width'));
 	}
 
 	/**

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004134) alex (manager) 2011-11-07 03:13	Will test all later together.

(0004135) alex (manager) 2011-11-07 03:14	Fix committed to 5.2.x branch. Commit Message: Fixes 0001158: Menu frame resize causes too much ajax requests

(0005061) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14734 Timestamp: 2011-11-07 03:14:56 Author: alex [ Details ] [ Diff ]	Fixes 0001158: Menu frame resize causes too much ajax requests
	mod - /in-portal/branches/5.2.x/core/admin_templates/tree.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/units/admin/admin_events_handler.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005061
2012-07-25 05:32	alex	Status	resolved => closed
2011-11-07 03:14	alex	Changeset attached	5.2.x r14734
2011-11-07 03:14	alex	Note Added: 0004135
2011-11-07 03:14	alex	Status	reviewed and tested => resolved
2011-11-07 03:14	alex	Fixed in Version	=> 5.2.0-B1
2011-11-07 03:14	alex	Resolution	open => fixed
2011-11-07 03:14	alex	Assigned To	!COMMUNITY => alex
2011-11-07 03:13	alex	Note Added: 0004134
2011-11-07 03:13	alex	Status	needs testing => reviewed and tested
2011-11-07 03:13	alex	Assigned To	=> !COMMUNITY
2011-11-07 03:13	alex	Developer	=> alex
2011-11-07 03:13	alex	Status	active => needs testing
2011-11-07 03:13	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/Uhs-9J9H5aY/discussion
2011-11-07 03:12	alex	New Issue
2011-11-07 03:12	alex	File Added: admin_menu_width_saving_fix.patch
2011-11-07 03:12	alex	Change Log Message	=> Optimizing ajax requests that are sent to save admin menu frame width
2011-11-07 03:12	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS