Anonymous | Login | Signup for a new account | 2024-04-20 03:25 CDT |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ] | [ View Simple ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001144 | [In-Portal CMS] Install / Upgrages | bug report | always | 2011-10-17 07:49 | 2012-07-25 05:32 | ||
Reporter | alex | View Status | public | Project Name | In-Commerce | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Platform | |||
Status | closed | OS | |||||
OS Version | |||||||
ETA | none | Fixed in Version | 5.2.0-B1 | Product Version | 5.1.3 | ||
Target Version | 5.2.0 | Product Build | |||||
Time Estimate | No estimate | ||||||
Summary | 0001144: Checking Affiliate during installation cause sql error | ||||||
Description |
I've noticed, that since 5.1.3 version we've got 1 more error during installation: SELECT Affiliates.* ,(u.PortalUserId) AS `UserId`,(IF( LENGTH(u.Login), u.Login, '')) AS `UserName`,(ap.Name) AS `PlanName`,(Affiliates.LastPaymentDate) AS `LastPaymentDate_date`,(Affiliates.LastPaymentDate) AS `LastPaymentDate_time`,(Affiliates.LastOrderDate) AS `LastOrderDate_date`,(Affiliates.LastOrderDate) AS `LastOrderDate_time`,(Affiliates.CreatedOn) AS `CreatedOn_date`,(Affiliates.CreatedOn) AS `CreatedOn_time` FROM Affiliates LEFT JOIN PortalUser u ON Affiliates.PortalUserId = u.PortalUserId LEFT JOIN AffiliatePlans ap ON Affiliates.AffiliatePlanId = ap.AffiliatePlanId WHERE (`Affiliates`.PortalUserId = '-1') LIMIT 0,1 happening from OrdersEventHandler->isAffiliate method on "Modules to Install" step. This is because installation wizard now uses the same method for logging user in as Front-End code. That's why I propose to skip affiliate checks during installation. |
||||||
Steps To Reproduce | |||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-bugs/ov0hRPOKcPM/discussion | ||||||
Change Log Message | Fixed sql error during installation | ||||||
Estimate Points | 0 | ||||||
Attached Files |
affiliate_on_install_modules_1144.patch [^] (585 bytes) 2011-11-02 11:41
[Show Content]
affiliate_check_during_installation.patch [^] (1,336 bytes) 2011-11-03 06:03 [Show Content] |
||||||
|
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0004115) Dmitry (manager) 2011-11-01 23:03 edited on: 2011-11-01 23:03 |
Moved to 5.2.0 release |
(0004121) erik (manager) 2011-11-02 11:42 |
patch attached - needs testing |
(0004126) alex (manager) 2011-11-03 06:04 |
Check was correct, but was performed in a wrong place. Problem was, that ord:OnUserLogin hook that triggered problematic affiliate check was called after user entered "root" user password during installation. That's the place where IS_INSTALL constant must be checked in this case. |
(0004127) alex (manager) 2011-11-03 06:05 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001144: Checking Affiliate during installation cause sql error Commit on behalf of Erik |
(0005064) alex (manager) 2012-07-25 05:32 |
Since 5.2.0 version was released. |
Related Changesets | |||
Modules :: In-Commerce: 5.2.x r14729 Timestamp: 2011-11-03 06:05:14 Author: alex [ Details ] [ Diff ] |
Fixes 0001144: Checking Affiliate during installation cause sql error Commit on behalf of Erik |
||
mod - /w/in-commerce/branches/5.2.x/units/orders/orders_event_handler.php | [ Diff ] [ File ] | ||
Issue History | |||
Date Modified | Username | Field | Change |
2012-07-25 05:32 | alex | Note Added: 0005064 | |
2012-07-25 05:32 | alex | Status | resolved => closed |
2011-11-03 06:05 | alex | Note Added: 0004127 | |
2011-11-03 06:05 | alex | Status | reviewed and tested => resolved |
2011-11-03 06:05 | alex | Fixed in Version | => 5.2.0-B1 |
2011-11-03 06:05 | alex | Resolution | open => fixed |
2011-11-03 06:05 | alex | Changeset attached | 5.2.x r14729 |
2011-11-03 06:04 | alex | Note Added: 0004126 | |
2011-11-03 06:04 | alex | Status | needs testing => reviewed and tested |
2011-11-03 06:03 | alex | File Added: affiliate_check_during_installation.patch | |
2011-11-02 11:42 | erik | Note Added: 0004121 | |
2011-11-02 11:42 | erik | Assigned To | erik => alex |
2011-11-02 11:42 | erik | Developer | => erik |
2011-11-02 11:42 | erik | Status | needs work => needs testing |
2011-11-02 11:41 | erik | File Added: affiliate_on_install_modules_1144.patch | |
2011-11-01 23:03 | Dmitry | Note Edited: 0004115 | View Revisions |
2011-11-01 23:03 | Dmitry | Estimate Points | => 0 |
2011-11-01 23:03 | Dmitry | Note Added: 0004115 | |
2011-11-01 23:03 | Dmitry | Assigned To | => erik |
2011-11-01 23:03 | Dmitry | Status | active => needs work |
2011-11-01 23:03 | Dmitry | Target Version | 5.1.4 => 5.2.0 |
2011-10-17 07:49 | alex | New Issue | |
2011-10-17 07:49 | alex | Reference | => https://groups.google.com/d/topic/in-portal-bugs/ov0hRPOKcPM/discussion |
2011-10-17 07:49 | alex | Change Log Message | => Fixed sql error during installation |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic In-Portal Open Source CMS |