In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Simple ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/Ur9GPbfLOTs/discussion

Change Log Message

Fixed problems with user modification time never shown/updated

Estimate Points

Attached Files

user_modified_field_not_working.patch [^] (6,453 bytes) 2011-08-24 03:45 [Show Content]

Index: admin/system_presets/simple/users_u.php
===================================================================
--- admin/system_presets/simple/users_u.php	(revision 14476)
+++ admin/system_presets/simple/users_u.php	(working copy)
@@ -108,14 +108,14 @@
 	// hide columns in grids
 	$hide_columns = Array (
 //		currently not in user
-//		'Default'	=>	Array ('Login', 'LastName', 'FirstName', 'Email', 'PrimaryGroup', 'CreatedOn'),
+//		'Default'	=>	Array ('Login', 'LastName', 'FirstName', 'Email', 'PrimaryGroup', 'CreatedOn', 'Modified'),
 
 //		user selector
-//		'UserSelector' => Array ('Login', 'LastName', 'FirstName', 'Email', 'PrimaryGroup', 'CreatedOn'),
+//		'UserSelector' => Array ('Login', 'LastName', 'FirstName', 'Email', 'PrimaryGroup', 'CreatedOn', 'Modified'),
 
 //		admins list; section: Users Management -> Administrators
 //		'Admins' => Array ('PortalUserId', 'Login', 'FirstName', 'LastName', 'Email'),
 
 //		users list; section: Users Management -> Users
-		'RegularUsers' => Array (/*'PortalUserId', 'Login', 'FirstName', 'LastName', 'Email',*/ 'PrimaryGroup', 'CreatedOn', /* 'Status'*/),
+		'RegularUsers' => Array (/*'PortalUserId', 'Login', 'FirstName', 'LastName', 'Email',*/ 'PrimaryGroup', 'CreatedOn', 'Modified', /* 'Status'*/),
 	);
Index: core/admin_templates/users/users_edit.tpl
===================================================================
--- core/admin_templates/users/users_edit.tpl	(revision 14476)
+++ core/admin_templates/users/users_edit.tpl	(working copy)
@@ -83,9 +83,10 @@
 			<inp2:m_RenderElement name="inp_edit_options" prefix="u" field="Country" title="la_fld_Country" has_empty="1"/>
 			<inp2:m_RenderElement name="inp_edit_multioptions" prefix="u" field="DisplayToPublic" title="la_fld_DisplayToPublic"/>
 
-		<inp2:m_RenderElement name="subsection" prefix="u" fields="Status,CreatedOn" title="la_section_Properties"/>
+		<inp2:m_RenderElement name="subsection" prefix="u" fields="Status,CreatedOn,Modified" title="la_section_Properties"/>
 			<inp2:m_RenderElement name="inp_edit_radio" prefix="u" field="Status" title="la_fld_Status"/>
 			<inp2:m_RenderElement name="inp_edit_date_time" prefix="u" field="CreatedOn" title="la_fld_CreatedOn"/>
+			<inp2:m_RenderElement name="inp_edit_date_time" prefix="u" field="Modified" title="la_fld_Modified"/>
 
 		<inp2:m_if check="m_ModuleEnabled" module="In-Portal">
 			<!-- custom fields: begin -->
Index: core/install/upgrades.sql
===================================================================
--- core/install/upgrades.sql	(revision 14487)
+++ core/install/upgrades.sql	(working copy)
@@ -2039,4 +2039,8 @@
 
 UPDATE Phrase
 SET l<%PRIMARY_LANGUAGE%>_Translation = 'User name length (min - max)'
-WHERE PhraseKey = 'LA_TEXT_MIN_USERNAME' AND l<%PRIMARY_LANGUAGE%>_Translation = 'Minimum user name length';
\ No newline at end of file
+WHERE PhraseKey = 'LA_TEXT_MIN_USERNAME' AND l<%PRIMARY_LANGUAGE%>_Translation = 'Minimum user name length';
+
+# ===== v 5.1.3 =====
+UPDATE PortalUser
+SET Modified = NULL;
\ No newline at end of file
Index: core/units/users/users_config.php
===================================================================
--- core/units/users/users_config.php	(revision 14489)
+++ core/units/users/users_config.php	(working copy)
@@ -393,7 +393,7 @@
 							        ),
 							        'ResourceId' => Array('type' => 'int','not_null' => 1, 'default' => 0),
 							        'Status' => Array('type' => 'int', 'formatter'=>'kOptionsFormatter', 'options'=>Array(1=>'la_Enabled', 0=>'la_Disabled', 2=>'la_Pending'), 'use_phrases'=>1, 'not_null' => 1, 'default' => 1),
-							        'Modified' => Array('type' => 'int', 'formatter' => 'kDateFormatter', 'default' => '#NOW#'),
+							        'Modified' => Array('type' => 'int', 'formatter' => 'kDateFormatter', 'default' => NULL),
 							        'dob' => Array('type'=>'int', 'formatter' => 'kDateFormatter', 'default' => NULL),
 							        'tz' => Array('type' => 'int', 'default' => NULL),
 							        'ip' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
@@ -495,6 +495,7 @@
 									'Email'			=> Array( 'title'=>'la_col_Email', 'filter_block' => 'grid_like_filter'),
 									'PrimaryGroup'	=> Array( 'title'=>'la_col_PrimaryGroup', 'filter_block' => 'grid_like_filter'),
 									'CreatedOn'	=>	Array('title' => 'la_col_CreatedOn', 'filter_block' => 'grid_date_range_filter'),
+									'Modified'	=>	Array('title' => 'la_col_Modified', 'filter_block' => 'grid_date_range_filter'),
 									'Status'		=> Array ('title' => 'la_col_Status', 'filter_block' => 'grid_options_filter', 'width' => 100, ),
 								),
 						),
@@ -514,6 +515,7 @@
 								'Email'			=> Array ('title' => 'la_col_Email', 'filter_block' => 'grid_like_filter', 'width' => 200, ),
 								'PrimaryGroup'	=> Array( 'title'=>'la_col_PrimaryGroup', 'filter_block' => 'grid_like_filter', 'width' => 100, ),
 								'CreatedOn'	=>	Array('title' => 'la_col_CreatedOn', 'filter_block' => 'grid_date_range_filter', 'width' => 150, ),
+								'Modified'	=>	Array('title' => 'la_col_Modified', 'filter_block' => 'grid_date_range_filter', 'width' => 150, ),
 								'Status'		=> Array ('title' => 'la_col_Status', 'filter_block' => 'grid_options_filter', 'width' => 100, ),
 							),
 						),
@@ -551,6 +553,7 @@
 								'PrimaryGroup'	=> Array ('title' => 'la_col_PrimaryGroup', 'filter_block' => 'grid_like_filter', 'width' => 140),
 								'Status'		=> Array ('title' => 'la_col_Status', 'filter_block' => 'grid_options_filter', 'width' => 100, ),
 								'CreatedOn'		=> Array ('title' => 'la_col_CreatedOn', 'filter_block' => 'grid_date_range_filter', 'width' => 100),
+								'Modified'		=> Array ('title' => 'la_col_Modified', 'filter_block' => 'grid_date_range_filter', 'width' => 100),
 							),
 						),
 					),
Index: core/units/users/users_event_handler.php
===================================================================
--- core/units/users/users_event_handler.php	(revision 14489)
+++ core/units/users/users_event_handler.php	(working copy)
@@ -930,6 +930,12 @@
 			/* @var $object UsersItem */
 
 			$object->setLogin();
+			$changed_fields = array_keys( $object->GetChangedFields() );
+
+			if ( $changed_fields && !in_array('Modified', $changed_fields) ) {
+				$object->SetDBField('Modified_date', adodb_mktime());
+				$object->SetDBField('Modified_time', adodb_mktime());
+			}
 		}
 
 		/**

user_modified_column_phrase_core_fix.patch [^] (776 bytes) 2011-09-19 02:04 [Show Content]

Index: units/users/users_config.php
===================================================================
--- units/users/users_config.php	(revision 14544)
+++ units/users/users_config.php	(working copy)
@@ -553,7 +553,7 @@
 								'PrimaryGroup'	=> Array ('title' => 'la_col_PrimaryGroup', 'filter_block' => 'grid_like_filter', 'width' => 140),
 								'Status'		=> Array ('filter_block' => 'grid_options_filter', 'width' => 100, ),
 								'CreatedOn'		=> Array ('filter_block' => 'grid_date_range_filter', 'width' => 100),
-								'Modified'		=> Array ('title' => 'la_col_Modified', 'filter_block' => 'grid_date_range_filter', 'width' => 100),
+								'Modified'		=> Array ('filter_block' => 'grid_date_range_filter', 'width' => 100),
 							),
 						),
 					),

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003705) Dmitry (manager) 2011-09-02 17:32	Reviewed and tested good. Please commit

(0003712) alex (manager) 2011-09-03 09:34	Fix committed to 5.1.x branch. Commit Message: Fixes 0001109: Field Modified (modification date/time) of PortalUser table isn't property updated

(0003713) alex (manager) 2011-09-03 09:35	I already commited, so it's easier to move this task to 5.1.3, rather then uncommit.

(0003763) Dmitry (manager) 2011-09-18 22:09	Looks like we are missing a Label or Translation for this column in Admin - Users. Please see 2 screens: http://screencast.com/t/MVQz6yWf http://screencast.com/t/1nJWjaP80f Fix and commit. Not sure if this is directly related to 0001094 task.

(0003765) alex (manager) 2011-09-19 01:57	Why you don't attach images directly to task, like before?

(0003766) alex (manager) 2011-09-19 02:04	Patch "user_modified_column_phrase_core_fix.patch" fixes problem after applying patch from 0001094 task.

(0003767) alex (manager) 2011-09-19 02:06	Fix committed to 5.1.x branch. Commit Message: Fixes 0001109: Field Modified (modification date/time) of PortalUser table isn't property updated 1. fixing column phrase

(0003770) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14545 Timestamp: 2011-09-19 02:06:07 Author: alex [ Details ] [ Diff ]	Fixes 0001109: Field Modified (modification date/time) of PortalUser table isn't property updated 1. fixing column phrase
	mod - /in-portal/branches/5.1.x/core/units/users/users_config.php	[ Diff ] [ File ]

In-Portal CMS: 5.1.x r14514 Timestamp: 2011-09-03 09:34:17 Author: alex [ Details ] [ Diff ]	Fixes 0001109: Field Modified (modification date/time) of PortalUser table isn't property updated
	mod - /in-portal/branches/5.1.x/admin/system_presets/simple/users_u.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/admin_templates/users/users_edit.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/install/upgrades.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/users/users_config.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/users/users_event_handler.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003770
2011-09-19 16:08	alex	Status	resolved => closed
2011-09-19 02:06	alex	Note Added: 0003767
2011-09-19 02:06	alex	Status	needs testing => resolved
2011-09-19 02:06	alex	Assigned To	!COMMUNITY => alex
2011-09-19 02:06	alex	Changeset attached	5.1.x r14545
2011-09-19 02:05	alex	Assigned To	alex => !COMMUNITY
2011-09-19 02:05	alex	Status	needs work => needs testing
2011-09-19 02:04	alex	Note Added: 0003766
2011-09-19 02:04	alex	File Added: user_modified_column_phrase_core_fix.patch
2011-09-19 01:57	alex	Note Added: 0003765
2011-09-18 22:09	Dmitry	Note Added: 0003763
2011-09-18 22:09	Dmitry	Status	resolved => needs work
2011-09-03 09:35	alex	Note Added: 0003713
2011-09-03 09:35	alex	Target Version	Icebox => 5.1.3
2011-09-03 09:34	alex	Changeset attached	5.1.x r14514
2011-09-03 09:34	alex	Note Added: 0003712
2011-09-03 09:34	alex	Status	reviewed and tested => resolved
2011-09-03 09:34	alex	Fixed in Version	=> 5.1.3
2011-09-03 09:34	alex	Resolution	open => fixed
2011-09-03 09:34	alex	Assigned To	!COMMUNITY => alex
2011-09-02 17:32	Dmitry	Note Added: 0003705
2011-09-02 17:32	Dmitry	Status	needs testing => reviewed and tested
2011-08-24 03:45	alex	Assigned To	=> !COMMUNITY
2011-08-24 03:45	alex	Developer	=> alex
2011-08-24 03:45	alex	Status	active => needs testing
2011-08-24 03:45	alex	New Issue
2011-08-24 03:45	alex	File Added: user_modified_field_not_working.patch
2011-08-24 03:45	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/Ur9GPbfLOTs/discussion
2011-08-24 03:45	alex	Change Log Message	=> Fixed problems with user modification time never shown/updated

Web Development by Intechnic

In-Portal Open Source CMS