In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]  [ Related Changesets ] [ View Simple ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001077 [In-Portal CMS] Data Management bug report always 2011-07-05 03:40 2012-07-25 05:33
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status closed   OS
  OS Version
ETA none Fixed in Version 5.2.0-B1 Product Version 5.1.0-B2
  Target Version 5.2.0 Product Build
Time EstimateNo estimate
Summary 0001077: Problems with category item import
Description Here several problem with category item import I've found recently:

1. When in "Popup Mode", then pressing "Cancel" button on last import step will replace left (menu) frame (and not right frame) import template.

2. No matter what category is specified in CSV file, but any created product will have target import category set as primary and a category from CSV file as secondary (problem, since "Parent Section" field appeared on an editing form).

3. Columns "Category1", "Category2", ..., "CategoryN" from CSV file are ignored during import, when they are manually specified in import column list (in automatic column detection mode they work).
Steps To Reproduce
Additional Information Solution to 1st problem could me showing import dialog in right frame directly and not in popup/modal window as we do right now.

Solution to 2nd problem could be setting CategoryId virtual field of a category item to a category, found in CSV file (if it was found there) before creating it (category item) in database.

Patch "wrong_category_import_logic.patch" contains a fix for a 3rd problem.
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/DSwcCRKRWHE/discussion
Change Log Message Fixes category processing problems on category item import
Estimate Points 2
Attached Files patch file icon wrong_category_import_logic.patch [^] (645 bytes) 2011-07-05 03:40 [Show Content]
patch file icon categoryitem_import_problems_core.patch [^] (5,993 bytes) 2011-07-06 05:57 [Show Content]
patch file icon categoryitem_import_problems_modules.patch [^] (54,942 bytes) 2011-07-06 05:58 [Show Content]
csv file icon test.csv [^] (116 bytes) 2011-09-07 17:57
patch file icon categoryitem_import_problems_core.2.patch [^] (8,402 bytes) 2011-10-14 12:17 [Show Content]
patch file icon categoryitem_import_problems_modules.2.patch [^] (52,845 bytes) 2011-10-14 12:17 [Show Content]
patch file icon categoryitem_import_problems_core_v3.patch [^] (50,510 bytes) 2011-10-19 05:54 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate 0001113closed (Icebox)!COMMUNITY There is an error in category parsing during category item import 

-  Notes
User avatar (0003588)
alex (manager)
2011-07-06 06:00
edited on: 2011-07-06 06:02

 Last 2 patches include 1st patch!

All of described fixed, plus did these bonus fixes:
1. in "Same Window" mode all edit forms now have borders around them
2. import dialog step 3 page (for each module) now has "Prev", "Import" buttons instead of "Import", "Cancel" buttons as before (I thought that Prev button, available on import steps 1 and 2 is missing on step 3 and added it)
3. changed default CSV field separator to "," from ", ", since "fgetcsv" function only allowed 1 symbol separator and raised warning on every import step (besides last MS Excel version wasn't understanding ", " separator too).
User avatar (0003722)
Dmitry (manager)
2011-09-07 17:48
edited on: 2011-09-07 17:58

 Moving to 5.1.3.

Tested okay with fewer Import related issues that needs to be fixed before committing:

1. In Modal Window mode after the Import is successful window shows the catalog while in normal conditions should close up and refresh the Catalog. This works before the Patch.

2. For some reason Status field value is always Disabled. I tried putting "1" or "Active" with no luck. I know this worked before.

3. For some reason CreatedById field is required during the Import why it hasn't been before (at least some versions ago).


NOTE: See products Export file used as example for tests


As to the rest it's working good.
User avatar (0004048)
erik (manager)
2011-10-14 12:19

 1. Initially I had same effect, but later this effect evaporated - import never opens as Modal Window - no dependance of UsePopups configuration value. Maybe, initially something was cached in the browser.

2. Status field was disabled because CreatedById field is required and not present in the import file - such case is fixed in the new patch.

3. Yes, CreatedById field is required for category items. This is defined in particular category items unit config files, as rule.

In the 2nd version of the patch additionally fixed behavior on pressing Cancel button - ensured redirect to the catalog.

new patch failes attached:
1) categoryitem_import_problems_core.2.patch
2) categoryitem_import_problems_modules.2.patch
User avatar (0004079)
alex (manager)
2011-10-19 05:54

 Major:
======
1. Import wasn't working when CSV file to be imported haven't CreatedById column at all - fixed

Minor:
======
1. Records in Skins table wasn't updated in core/install/install_data.sql

2. File "core/install/upgrades.css" changes were made for 5.1.3-B1 and not for 5.2.0 version
User avatar (0004080)
alex (manager)
2011-10-19 05:57

 Fix committed to 5.2.x branch. Commit Message:

Fixes 0001077: Problems with category item import
Commit on behalf of Erik
User avatar (0005122)
alex (manager)
2012-07-25 05:33

 Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14685
Timestamp: 2011-10-19 05:57:03
Author: alex
[ Details ] [ Diff ] 		Fixes 0001077: Problems with category item import
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/header.tpl [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/style_template.css [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/js/forms.js [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.css [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/kernel/db/cat_event_handler.php [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/units/admin/admin_events_handler.php [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/cat_dbitem_export_helper.php [ Diff ] [ File ]
Modules :: In-News: 5.2.x r14684
Timestamp: 2011-10-19 05:55:52
Author: alex
[ Details ] [ Diff ] 		Bug 0001077: Problems with category item import
Commit on behalf of Erik
mod - /modules/in-news/branches/5.2.x/admin_templates/import.tpl [ Diff ] [ File ]
mod - /modules/in-news/branches/5.2.x/units/articles/articles_config.php [ Diff ] [ File ]
Modules :: In-Link: 5.2.x r14683
Timestamp: 2011-10-19 05:55:42
Author: alex
[ Details ] [ Diff ] 		Bug 0001077: Problems with category item import
Commit on behalf of Erik
mod - /modules/in-link/branches/5.2.x/admin_templates/import.tpl [ Diff ] [ File ]
mod - /modules/in-link/branches/5.2.x/units/links/links_config.php [ Diff ] [ File ]
Modules :: In-Commerce: 5.2.x r14682
Timestamp: 2011-10-19 05:55:28
Author: alex
[ Details ] [ Diff ] 		Bug 0001077: Problems with category item import
Commit on behalf of Erik
mod - /w/in-commerce/branches/5.2.x/admin_templates/import.tpl [ Diff ] [ File ]
mod - /w/in-commerce/branches/5.2.x/units/orders/orders_config.php [ Diff ] [ File ]
mod - /w/in-commerce/branches/5.2.x/units/products/products_config.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005122
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:25 alex Estimate Points => 2
2011-10-19 05:57 alex Note Added: 0004080
2011-10-19 05:57 alex Status reviewed and tested => resolved
2011-10-19 05:57 alex Fixed in Version => 5.2.0-B1
2011-10-19 05:57 alex Resolution open => fixed
2011-10-19 05:57 alex Assigned To !COMMUNITY => alex
2011-10-19 05:57 alex Changeset attached 5.2.x r14685
2011-10-19 05:55 alex Changeset attached 5.2.x r14684
2011-10-19 05:55 alex Changeset attached 5.2.x r14683
2011-10-19 05:55 alex Changeset attached 5.2.x r14682
2011-10-19 05:54 alex Note Added: 0004079
2011-10-19 05:54 alex Assigned To alex => !COMMUNITY
2011-10-19 05:54 alex Status needs testing => reviewed and tested
2011-10-19 05:54 alex File Added: categoryitem_import_problems_core_v3.patch
2011-10-14 12:19 erik Time Estimate Removed 1 =>
2011-10-14 12:19 erik Note Added: 0004048
2011-10-14 12:19 erik Assigned To erik => alex
2011-10-14 12:19 erik Developer alex => erik
2011-10-14 12:19 erik Status needs work => needs testing
2011-10-14 12:17 erik File Added: categoryitem_import_problems_modules.2.patch
2011-10-14 12:17 erik File Added: categoryitem_import_problems_core.2.patch
2011-10-13 10:36 Dmitry Assigned To alex => erik
2011-09-27 05:06 alex Time Estimate Added 1
2011-09-23 22:11 Dmitry Target Version Icebox => 5.2.0
2011-09-07 17:58 Dmitry Note Edited: 0003722 View Revisions
2011-09-07 17:57 Dmitry File Added: test.csv
2011-09-07 17:48 Dmitry Note Edited: 0003722 View Revisions
2011-09-07 17:48 Dmitry Note Added: 0003722
2011-09-07 17:48 Dmitry Assigned To !COMMUNITY => alex
2011-09-07 17:48 Dmitry Status needs testing => needs work
2011-08-24 05:01 alex Relationship added has duplicate 0001113
2011-07-06 06:02 alex Note Edited: 0003588 View Revisions
2011-07-06 06:00 alex Note Added: 0003588
2011-07-06 06:00 alex Assigned To => !COMMUNITY
2011-07-06 06:00 alex Developer => alex
2011-07-06 06:00 alex Status active => needs testing
2011-07-06 05:58 alex File Added: categoryitem_import_problems_modules.patch
2011-07-06 05:57 alex File Added: categoryitem_import_problems_core.patch
2011-07-05 03:40 alex New Issue
2011-07-05 03:40 alex File Added: wrong_category_import_logic.patch
2011-07-05 03:40 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/DSwcCRKRWHE/discussion
2011-07-05 03:40 alex Change Log Message => Fixes category processing problems on category item import

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker